> > Looks like commit f663dd9aaf9e ("net: core: explicitly select a txq > > before doing l2 forwarding") has removed the need for this dedicated > > xmit function [it even explicitly states so in its commit log message] > > but it hasn't removed the definition of the ndo. > > > > Signed-off-by: Yuval Mintz <yuval.mi...@cavium.com> > > Looks good, applied, thanks.
BTW, I've came across this while looking at ndo_dfwd_(add|del)_station, but it Seems to me like there are simply not enough notification points to reliably base the macvlan network-topology on in the offloader view. Specifically, in case there is a mix of private/bridge macvlan instances over a single lower-device, I can't see how the offloader could know and prevent packets from being internally routed to the private instances. Could someone perhaps clarify it a bit?