> > > +subsys_initcall(hnae3_init); > > > > And the point of this is? > > > > Andrew > This looks weird but not sure how we could have made sure HNAE is available > before other > 2 drivers could have loaded. Changing into module_init() means two other > modules (dependent > upon hnae) if loaded first will experience load time linking problems. Do you > think this > is okay?
Often the best way to decide if something is sensible is to see if lots of other drivers do the same. Can you point to other drivers doing this? depmod/modprobe will actually sort this out for you. depmod looks at the symbols exported and required for each module and builds a dependency tree. When you modprobe a driver, it looks at the dependency tree, and loads any drivers needed in order to fulfil the dependencies. Andrew