Hi Andrew, > -----Original Message----- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Wednesday, June 14, 2017 3:56 AM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil....@gmail.com; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 6/8] net: hns3: Add MDIO support to > HNS3 Ethernet driver for hip08 SoC > > > + if (le16_to_cpu(HCLGE_MDIO_STA_VAL(mdio_cmd->sta))) { > > + dev_err(&hdev->pdev->dev, "mdio read data error\n"); > > + return -ENOMEM; > > + } > > If it is not zero, it is an error. !0 is always !0, big or little > endian, so there is no point doing the le16_to_cpu(). > > Where is the memory allocation which failed? > > Andrew Agreed! Will remove this.
Thanks Salil
