On 6/16/17 6:36 AM, Vladislav Yasevich wrote:
There are some issues in macvlan wrt to changing it's mac address.
* An error is returned in the specified address is the same as an already
  assigned address.
* In passthru mode, the mac address of the macvlan device doesn't change.
* After changing the mac address of a passthru macvlan and then removing it,
  the mac address of the physical device remains changed.

This patch series attempts to resolve these issues.

Thanks
-vlad

Vladislav Yasevich (4):
  macvlan: Do not return error when setting the same mac address
  macvlan: Fix passthru macvlan mac address inheritance
  macvlan: convert port passthru to flags.

Above 3 patches looks good to me, so

Reviewed-by: Girish Moodalbail <girish.moodalb...@oracle.com>


  macvlan: Let passthru macvlan correctly restore lower mac address

However, I have few questions/comments on the above patch.

thanks,
~Girish


 drivers/net/macvlan.c | 85 ++++++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 71 insertions(+), 14 deletions(-)


Reply via email to