On Fri, 2017-06-16 at 00:12 +0200, Johannes Berg wrote: > From: Johannes Berg <johannes.b...@intel.com> [] > diff --git a/drivers/nfc/pn533/pn533.c b/drivers/nfc/pn533/pn533.c [] > @@ -2090,10 +2090,10 @@ static int pn533_fill_fragment_skbs(struct pn533 > *dev, struct sk_buff *skb) > > /* MI + TG */ > if (frag_size == PN533_CMD_DATAFRAME_MAXLEN) > - *skb_push(frag, sizeof(u8)) = > - (PN533_CMD_MI_MASK | 1); > - else > - *skb_push(frag, sizeof(u8)) = 1; /* TG */ > + *(u8 *)skb_push(frag, sizeof(u8)) = > + > (PN533_CMD_MI_MASK | 1); > + else > + *(u8 *)skb_push(frag, sizeof(u8)) = 1; > /* TG */
Can you check all the if/else uses. This one is not formatted correctly. I didn't look at any others.
