From: Lawrence Brakmo <bra...@fb.com> Date: Tue, 13 Jun 2017 10:59:54 -0700
> diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c > index d0642df..a0032ea 100644 > --- a/net/ipv4/tcp_minisocks.c > +++ b/net/ipv4/tcp_minisocks.c > @@ -352,6 +352,7 @@ void tcp_openreq_init_rwin(struct request_sock *req, > u32 window_clamp; > __u8 rcv_wscale; > int mss; > + u32 rcv_wnd; Please order local variables from longest to shortest line. ... > diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c > index 503e478..972a985 100644 > --- a/net/ipv4/tcp_output.c > +++ b/net/ipv4/tcp_output.c > @@ -3267,6 +3267,7 @@ static void tcp_connect_init(struct sock *sk) > const struct dst_entry *dst = __sk_dst_get(sk); > struct tcp_sock *tp = tcp_sk(sk); > __u8 rcv_wscale; > + u32 rcv_wnd; Likewise.
