From: Noriaki TAKAMIYA <[EMAIL PROTECTED]>
Date: Thu, 27 Jul 2006 19:49:29 +0900 (JST)

> >> Thu, 27 Jul 2006 11:28:02 +0100
> >> [Subject: Re: [RFC] [IPV6] ADDRCONF: Lifetime handling fixes] wrote...
> >> Hugo Santos <[EMAIL PROTECTED]> wrote...
> 
> > > + ifp = ipv6_get_ifaddr(pfx, dev, 1);
> > > + if (ifp == NULL)
> > > +         return -ENOENT;
> > > +
> > > + if (!valid_lft || (prefered_lft > valid_lft))
> > > +         return -EINVAL;
> >                 ^^^^^^^^^^^^^^^
> > 
> >    Unreleased ifp? This test should go before ipv6_get_ifaddr.
> 
>   That's right. Thanks.

Thank you Takamiya-san.

Besides this correction, the rest of the changes look fine to me.
I think we should get these fixes into 2.6.18, if you don't mind.

So please resubmit with the correction.

Thanks again.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to