On Monday, June 5, 2017 11:43:33 PM CEST Andrew Lunn wrote: > On Mon, Jun 05, 2017 at 10:49:40PM +0200, Christian Lamparter wrote: > > emac_mdio_read_link() was not copying the requested phy settings > > back into the emac driver's own phy api. This has caused a link > > speed mismatch issue for the AR8035 as the emac driver kept > > trying to connect with 10/100MBps on a 1GBit/s link.
> In the long run, you might want to remove the emac phy drivers. > Linux has PHYLIB drivers for all but the bcm5248. Hello Andrew Back in February I added PHYLIB support to emac. <https://www.spinics.net/lists/netdev/msg421734.html> ;) I could add a separate patch that adds a oneliner message like: pr_info("EMAC supports PHYLIB. Please convert your device to it.\n"); at the right place (emac_mii_phy_probe) to let people know about it. Is that Ok? If not, please tell me what the appropriate deprecation notice should look like. About the MR24: I do have a patchset to convert the MR24 to use PHYLIB's at803x as well. <https://github.com/chunkeey/apm82181-lede/commit/82c50b7f4fca68ce905d4a7a3559700635bf227f> But because of AT8035 "special tx/rx delay" requirements, this will need a patched at803x.c driver as well. Regards, Christian
