Wed, May 31, 2017 at 02:27:02PM CEST, jb...@redhat.com wrote:
>On Tue, 16 May 2017 19:29:37 +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <j...@mellanox.com>
>> 
>> Allow user to set control action "goto" with filter chain index as
>> a parameter.
>> 
>> Signed-off-by: Jiri Pirko <j...@mellanox.com>
>> ---
>>  include/linux/pkt_cls.h | 16 +++++++++++++++-
>>  man/man8/tc-ife.8       |  2 +-
>>  man/man8/tc-pedit.8     |  2 +-
>>  man/man8/tc-police.8    |  2 +-
>>  man/man8/tc-vlan.8      |  2 +-
>
>Jiri, this *seriously* needs a proper documentation. I consider myself
>to be well above average in understanding tc filters and actions, and as
>you know I participated at least passively in some chats about the
>chains. Yet I'm still very lost in semantics of chains. I cannot
>imagine how an average user would be able to use this.
>
>Some questions about the semantics:
>
>- What chain(s) are processed by default? If I don't use goto_chain but
>  have multiple chains, will only chain 0 be processed, or more? In
>  what order, what are the rules? If I don't have a chain 0, what would
>  happen?

0 only. I exepcter it makes sense. But you are right, I will put it to
man.


>
>- What is the relation between priorities and chains? I expected that
>  chains are under the same priority but that's not the case in your
>  example. For a user, it's very unclear why there are priorities and
>  chains. They appear to do the same thing, why can't I just jump
>  between priorities?

Basically, what we had previously was single chain (0) only. Now we have
multichain, each chain is completely independent list of tps, each tp
having its prio.



I will also add this to man.


>
>Please, in addition to explaining here on the list, add detailed
>explanation to the man pages.
>
>Thanks,
>
> Jiri

Reply via email to