On Sat, May 27, 2017 at 4:13 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > On Fri, May 26, 2017 at 7:07 PM, Jan Kiszka <jan.kis...@siemens.com> wrote: >> Make stmmac_default_data compatible with stmmac_pci_info.setup and use >> an info structure for all devices. This allows to make the probing more >> regular.
> Or converting defines first to PCI_DEVICE_ID_* It looks even for previously mentioned approach we need to rename constants first. > and > > #define STMMAC_DEVICE(_vid, _did, info) { \ > PCI_DEVICE(PCI_VENDOR_ID_##_vid, PCI_DEVICE_ID_##_did), > \ > > which I like even better. Or even #define STMMAC_DEVICE(_vid, _did, info) { \ PCI_VDEVICE(_vid, PCI_DEVICE_ID_##_did), \ -- With Best Regards, Andy Shevchenko