> On May 22, 2017, at 4:24 PM, SF Markus Elfring
> <elfr...@users.sourceforge.net> wrote:
>
> From: Markus Elfring <elfr...@users.sourceforge.net>
> Date: Mon, 22 May 2017 22:18:28 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Link:
> http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Reviewed-by: Chuck Lever <chuck.le...@oracle.com>
> ---
> net/sunrpc/xprtrdma/backchannel.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/net/sunrpc/xprtrdma/backchannel.c
> b/net/sunrpc/xprtrdma/backchannel.c
> index 24fedd4b117e..03f6b5840764 100644
> --- a/net/sunrpc/xprtrdma/backchannel.c
> +++ b/net/sunrpc/xprtrdma/backchannel.c
> @@ -119,11 +119,9 @@ int xprt_rdma_bc_setup(struct rpc_xprt *xprt, unsigned
> int reqs)
>
> for (i = 0; i < (reqs << 1); i++) {
> rqst = kzalloc(sizeof(*rqst), GFP_KERNEL);
> - if (!rqst) {
> - pr_err("RPC: %s: Failed to create bc rpc_rqst\n",
> - __func__);
> + if (!rqst)
> goto out_free;
> - }
> +
> dprintk("RPC: %s: new rqst %p\n", __func__, rqst);
>
> rqst->rq_xprt = &r_xprt->rx_xprt;
> --
> 2.13.0
--
Chuck Lever
