>> + if (padlen) { >> + u8 *pad = skb_put(nskb, padlen); >> + >> + memset(pad, 0, padlen); >> + } > >Can you use skb_put_padto() here instead of open coding this? > >> + >> + tag = skb_put(nskb, KSZ_INGRESS_TAG_LEN); >> + tag[0] = 0; >> + tag[1] = 1 << p->dp->index; /* destnation port */ > >typo: destination port > >With that fixed: > >Reviewed-by: Florian Fainelli <f.faine...@gmail.com> HI Florian,
Thanks for prompt reviews. Will submit another version. - Woojung