> From: Kirsher, Jeffrey T > Sent: Friday, May 19, 2017 1:17 AM > To: David Miller <[email protected]>; [email protected] > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; Neftin, Sasha > <[email protected]>; Brown, Aaron F <[email protected]>; > [email protected] > Subject: Re: [PATCH v2] e1000e: Don't return uninitialized stats > > On Thu, 2017-05-18 at 10:46 -0400, David Miller wrote: > > From: Benjamin Poirier <[email protected]> > > Date: Wed, 17 May 2017 16:24:13 -0400 > > > > > Some statistics passed to ethtool are garbage because > > > e1000e_get_stats64() > > > doesn't write them, for example: tx_heartbeat_errors. This leaks kernel > > > memory to userspace and confuses users. > > > > > > Do like ixgbe and use dev_get_stats() which first zeroes out > > > rtnl_link_stats64. > > > > > > Fixes: 5944701df90d ("net: remove useless memset's in drivers > > > get_stats64") > > > Reported-by: Stefan Priebe <[email protected]> > > > Signed-off-by: Benjamin Poirier <[email protected]>
Tested-by: Aaron Brown <[email protected]>
