Ben Greear <[EMAIL PROTECTED]> wrote:

>Jay Vosburgh wrote:
>
>>      Another possibility would be to have __vlan_hwaccel_rx check the
>> VLAN_DEV_INFO(skb->dev)->real_dev, and if that's a bonding device, apply
>> the same logic found in skb_bond().  Or, if there's some way to ask the
>> question "is dev a VLAN device?", then that same test could be put into
>> skb_bond() and all of the packet suppression fru fru could stay there.
>
>There is a flag in if.h to denote VLAN devices:

        Thanks, I missed that.

        Sadly, elegance remains elusive, since the by the time skb_bond
is called, the slave device the packet arrived on isn't available
(vlan->real_dev points to 'bond0' by this point), and that information
is needed to decide whether to drop the packet or not.

        The least grotty solution that comes to mind is to have
__vlan_hwaccel_rx call some skb_bond_suppress_dups() function directly,
and change skb_bond() to also call that function.

        -J

---
        -Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to