From: Neil Horman <nhor...@tuxdriver.com> Date: Fri, 12 May 2017 12:00:01 -0400
> There are several paths in vmxnet3, where settings changes cause the > adapter to be brought down and back up (vmxnet3_set_ringparam among > them). Should part of the reset operation fail, these paths call > vmxnet3_force_close, which enables all napi instances prior to calling > dev_close (with the expectation that vmxnet3_close will then properly > disable them again). However, vmxnet3_force_close neglects to clear > VMXNET3_STATE_BIT_QUIESCED prior to calling dev_close. As a result > vmxnet3_quiesce_dev (called from vmxnet3_close), returns early, and > leaves all the napi instances in a enabled state while the device itself > is closed. If a device in this state is activated again, napi_enable > will be called on already enabled napi_instances, leading to a BUG halt. > > The fix is to simply enausre that the QUIESCED bit is cleared in > vmxnet3_force_close to allow quesence to be completed properly on close. > > Signed-off-by: Neil Horman <nhor...@tuxdriver.com> Looks good, applied, thanks Neil.
