From: Duyck, Alexander H
> Sent: 27 April 2017 16:21
...
> > -unsigned int ipvlan_mac_hash(const unsigned char *addr)
> > +inline unsigned int ipvlan_mac_hash(const unsigned char *addr)
> >  {
> >     u32 hash = jhash_1word(__get_unaligned_cpu32(addr + 2),
> >                            ipvlan_jhash_secret);
> 
> I'm kind of surprised this isn't causing a problem with differing 
> declarations between the declaration
> here and the declaration in ipvlan.h. Normally for inlining something like 
> this you would change it to
> a "static inline" and move the entire declaration into the header file.

You get a callable copy for external callers and local calls inlined.
Not usually what you want.

        David

Reply via email to