On 17-04-26 09:17 AM, Jamal Hadi Salim wrote:
On 17-04-26 09:08 AM, Jiri Pirko wrote:
Wed, Apr 26, 2017 at 02:42:17PM CEST, j...@mojatatu.com wrote:
+#define VALID_TCA_ROOT_FLAGS TCA_FLAG_LARGE_DUMP_ON
+static inline bool tca_flags_valid(u32 act_flags)
+{
+ u32 invalid_flags_mask = ~VALID_TCA_ROOT_FLAGS;
+
+ if (act_flags & invalid_flags_mask)
+ return false;
+
+ return true;
This dance should either not be here (flag-per-attr) or should be in
netlink generic place. This is not TC specific at all.
So where do you think it should be?
It would also be helpful for you to make comments when these things
show up. This change was in version 6. I have had to do this back and
forth a few times.
cheers,
jamal
