From: Daniel Borkmann > Sent: 24 April 2017 15:41 > To: Alexander Alemayhu; netdev@vger.kernel.org > Cc: a...@fb.com > Subject: Re: [PATCH net-next 3/3] samples/bpf: check before defining offsetof > > On 04/24/2017 03:31 PM, Alexander Alemayhu wrote: > > Fixes the following warning > > > > samples/bpf/test_lru_dist.c:28:0: warning: "offsetof" redefined > > #define offsetof(TYPE, MEMBER) ((size_t)&((TYPE *)0)->MEMBER) > > > > In file included from ./tools/lib/bpf/bpf.h:25:0, > > from samples/bpf/libbpf.h:5, > > from samples/bpf/test_lru_dist.c:24: > > /usr/lib/gcc/x86_64-redhat-linux/6.3.1/include/stddef.h:417:0: note: this > > is the location of the > previous definition > > #define offsetof(TYPE, MEMBER) __builtin_offsetof (TYPE, MEMBER) > > > > Signed-off-by: Alexander Alemayhu <alexan...@alemayhu.com> > > Acked-by: Daniel Borkmann <dan...@iogearbox.net>
Isn't the correct fix to include stddef.h ? David