On Thu, 2017-04-20 at 02:01 +0200, Daniel Borkmann wrote: > > Yeah, should work as well for the 32 bit archs, on 64 bit we > have this effectively already:
Right. [...] > Can you elaborate on why this works for mac80211? It uses cb > only up to that point from where you invoke the prog? No, it works because then I can move a u64 field to the same offset, and save/restore it across the BPF call :) But I don't have a *pointer* field to move there, and no space for the alignment anyway (already using all 48 bytes). Come to think of it - somebody had proposed extensions to this by passing an on-stack pointer in addition to the data in the cb. Perhaps we can extend BPF to have an optional second argument, and track a second context around the verifier, if applicable? Then we can solve all of this really easily, because it means we don't always have to go from the SKB context but could go from the other one (which could be that on-stack buffer). Alternatively I can clear another pointer (u64) in the CB, store a pointer there, and always emit code following that pointer - should be possible right? johannes
