On 04/18/2017 02:06 AM, Gavin Shan wrote: > On Mon, Apr 17, 2017 at 01:36:19PM -0400, David Miller wrote: >> From: Cédric Le Goater <c...@kaod.org> >> Date: Fri, 14 Apr 2017 10:56:37 +0200 >> >>> htonl was used instead of ntohl. Surely a typo. >>> >>> Signed-off-by: Cédric Le Goater <c...@kaod.org> >> >> I don't think so, "checksum" is of type "u32" thus is in host byte >> order. Therefore "htonl()" is correct. >> > > Yeah, "htonl()" is correct here. "*pchecksum" is in big-endian. > I want to know how Cédric thinks it's a problem. I guess he might > encounter the issue on the emulated NCSI channel by QEMU.
yes exactly. my bad. After a second look this is correct. Sorry for the noise. > On BCM5718 or BCM5719, the checksum in AEN and response packet > are zero'd, meaning the software shouldn't validate it at all. Interesting. Thanks, C.
