From: James Morris <[EMAIL PROTECTED]>
Date: Thu, 13 Jul 2006 11:18:32 -0400 (EDT)

> I'd suggest assigning the return value to a variable and asserting that, 
> in case defines BUG_ON to nothing and the function won't be called.  Not 
> sure what kernel policy is on this (ISTR people used to worry about it), 
> but it's better not to take uncecessary chances.

There should never be side effects in BUG_ON() checks, just like
an assert().

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to