On Sun, Apr 09, 2017 at 06:22:36PM -0700, David Miller wrote: > From: Johannes Berg <johan...@sipsolutions.net> > Date: Fri, 7 Apr 2017 21:00:07 +0200 > > > From: Johannes Berg <johannes.b...@intel.com> > > > > There's no need to have struct bpf_prog_type_list since > > it just contains a list_head, the type, and the ops > > pointer. Since the types are densely packed and not > > actually dynamically registered, it's much easier and > > smaller to have an array of type->ops pointer. Also > > initialize this array statically to remove code needed > > to initialize it. > > > > Signed-off-by: Johannes Berg <johannes.b...@intel.com> > > If you just don't want to list things multiple times how about: > > linux/bpf_verifiers.h: > BPF_VERIFIER(BPF_PROG_TYPE_SOCKET_FILTER, sk_filter_prog_ops) > BPF_VERIFIER(BPF_PROG_TYPE_SCHED_CLS, tc_cls_prog_ops) > ... > > Then in bpf.h: > > #define BPF_VERIFIER(TYPE_VAL, SYM) extern const struct bpf_verifier_ops SYM; > #include <linux/bpf_verifiers.h" > > and in kernel/bpf/syscall.c: > > #define BPF_VERIFIER(TYPE_VAL, SYM) [TYPE_VAL] = &SYM, > #include <linux/bpf_verifiers.h" > > or something like that.
That is great suggestion! I like it.
