Re: [PATCH net-next RFC] Generic XDP

[Andrew Lunn]

> +     switch (act) {
> +     case XDP_PASS:
> +     case XDP_TX:
> +             break;
> +
> +     default:
> +             bpf_warn_invalid_xdp_action(act);

Hi David

You might want to put a /* fall through */ comment here, just to
prevent newbies from submitting patches moving the default clause to
the end.

    Andrew

> +     case XDP_ABORTED:
> +             trace_xdp_exception(skb->dev, xdp_prog, act);
> +     case XDP_DROP:
> +     do_drop:
> +             kfree_skb(skb);
> +             break;
> +     }
> +
> +     return act;
> +}