Hi Alex, On Apr 4 10:33, Alexander Duyck wrote: > On Tue, Apr 4, 2017 at 10:16 AM, Duyck, Alexander H > <alexander.h.du...@intel.com> wrote: > >> -----Original Message----- > >> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > >> Behalf Of Corinna Vinschen > >> Sent: Tuesday, April 4, 2017 8:11 AM > >> To: intel-wired-...@lists.osuosl.org > >> Cc: netdev@vger.kernel.org > >> Subject: [Intel-wired-lan] [PATCH] igb: Allow to remove administratively > >> set MAC > >> on VFs > >> [...] > > So I just realized there is one other minor issue I just found. In > igb_rar_set_qsel you should probably add a check for > "is_valid_ether_addr(addr)" before you set the E1000_RAH_AV bit. For > the zeroed MAC address it should be cleared so that we aren't > filtering on a MAC address of all 0's for the VF. > > - Alex
I see your point, but I'm a bit reluctant to do that because igb_vf_configure() calls igb_set_vf_mac() with addr set to the zeroed MAC explicitely: eth_zero_addr(mac_addr); igb_set_vf_mac(adapter, vf, mac_addr); So in this case the zero MAC is already treated as valid address and the E1000_RAH_AV bit is set. Is that just a bug? Corinna
signature.asc
Description: PGP signature
