Am Sonntag, 9. Juli 2006 17:49 schrieb Ivo Van Doorn:
> I have been quite busy lately, hence the reason for this late continuance
> of the Hardware button support for Wireless cards discussion.
> I have CC'ed the people who discussed this in earlier threads.
no problem. Look good, just one thing I'm missing:
> + For each registered hardware button an input device will be created.
> + If this input device has been opened by the user, rfkill will send a
> + signal to userspace instead of the hardware about the new button
> + status. This will allow userpace to perform the correct steps
> + in order to bring down all interfaces.
> + if (rfkill->input_dev->users) {
> + input_report_key(rfkill->input_dev,
> + KEY_RFKILL, new_status);
> + input_sync(rfkill->input_dev);
Shouldn't there be a continue to avoid calling enable/disable_radio()?
> + }
Stefan
PS: This rfkill stuff is really caught between two stools. Sending a netlink
event for the device with an additional TLV for radio button status seems as
valid as sending an input event...
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
