From: Thierry Reding <tred...@nvidia.com> Date: Thu, 30 Mar 2017 16:34:36 +0200
> On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: >> > From: Arnd Bergmann <a...@arndb.de> >> > Date: Tue, 28 Mar 2017 11:48:21 +0200 >> > >> > > A driver must not access the two fields directly but should instead use >> > > the helper functions to set the values and keep a consistent internal >> > > state: >> > > >> > > ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_dvr_probe': >> > > ethernet/stmicro/stmmac/stmmac_main.c:4083:8: error: 'struct net_device' >> > > has no member named 'real_num_rx_queues'; did you mean >> > > 'real_num_tx_queues'? >> > > >> > > Fixes: a8f5102af2a7 ("net: stmmac: TX and RX queue priority >> > > configuration") >> > > Signed-off-by: Arnd Bergmann <a...@arndb.de> >> > >> > Applied. >> >> This break my revert patch. (since it patch ("net: stmmac: enable multiple >> buffers"). >> Since dwmac-sunxi is still broken, what can I do ? send two revert patch ? >> or adapt the reverting patch. > > Have you tried if the kcalloc() patch I sent on Tuesday fixes things the > issues introduced by the multiple buffers patch? Niklas reported that it > restores functionality on his setup. I think he said yesterday that he did indeed test all of your patches and it did not fix things for him. http://marc.info/?l=linux-kernel&m=149076922813085&w=2 I am going to revert the enable multiple buffers commit, and I would ask that all involved parties work together in the background to resolve all of this. Thank you.