On Mon, 27 Mar 2017 23:49:05 +0300, Saeed Mahameed wrote:
> mlx5e_redirect_rqts_to_{channels,drop} and mlx5e_{add,del}_sqs_fwd_rules
> and Set real num tx/rx queues belong to
> mlx5e_{activate,deactivate}_priv_channels, for that we move those functions
> and minimize mlx5e_open/close flows.
>
> This will be needed in downstream patches to replace old channels with new
> ones without the need to call mlx5e_close/open.
>
> Signed-off-by: Saeed Mahameed <sae...@mellanox.com>
> Reviewed-by: Tariq Toukan <tar...@mellanox.com>
Nice series! Let me share some experiences below...
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 40
> +++++++++++------------
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 10 ++++--
> 2 files changed, 26 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> index a6e09c46440b..a94f84ec2c1a 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> @@ -2498,14 +2498,33 @@ static void mlx5e_build_channels_tx_maps(struct
> mlx5e_priv *priv)
>
> static void mlx5e_activate_priv_channels(struct mlx5e_priv *priv)
> {
> + int num_txqs = priv->channels.num * priv->channels.params.num_tc;
> + struct net_device *netdev = priv->netdev;
> +
> + mlx5e_netdev_set_tcs(netdev);
> + if (netdev->real_num_tx_queues != num_txqs)
> + netif_set_real_num_tx_queues(netdev, num_txqs);
netif_set_real_num_{r,t}x_queues() is the only thing stopping us from
achieving perfection :) When new queues are allocated these calls may
fail. I remember writing a "try to do increases first" helper but
ultimately didn't think it was worth while. Perhaps we can revisit
that if more drivers move to this paradigm...
> + if (netdev->real_num_rx_queues != priv->channels.num)
Arnd pointed out to me in:
08348995c47e ("netronome: don't access real_num_rx_queues directly")
that read_num_rx_queues is under CONFIG_SYSFS :)
> + netif_set_real_num_rx_queues(netdev, priv->channels.num);
