On Sun, 2006-09-07 at 17:54 +0200, Thomas Graf wrote:

> Look at where dev->queue_lock is taken, whenever a qdisc or
> filter is added, modified or deleted the lock is taken. Using
> your approach packets get dropped while such an operation is
> taking place. 

True, this will be bad for devices that dont care about any of this
(looping etc).
Perhaps it may even have been a reason that held me back - i dont
remember and it doesnt matter.
So go ahead and submit a patch while keeping in mind the same reasoning
as above.

> Your approach is wrong.

And this is where we are going to go into a loop. Do you want to go that
path? I suggest we dont.

cheers,
jamal

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to