From: Florian Westphal <f...@strlen.de>

as comment says, the function is always called with rcu read lock held.

Signed-off-by: Florian Westphal <f...@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org>
---
 net/bridge/br_netfilter_hooks.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/bridge/br_netfilter_hooks.c b/net/bridge/br_netfilter_hooks.c
index 95087e6e8258..52739e6c610e 100644
--- a/net/bridge/br_netfilter_hooks.c
+++ b/net/bridge/br_netfilter_hooks.c
@@ -1016,13 +1016,10 @@ int br_nf_hook_thresh(unsigned int hook, struct net 
*net,
        if (!elem)
                return okfn(net, sk, skb);
 
-       /* We may already have this, but read-locks nest anyway */
-       rcu_read_lock();
        nf_hook_state_init(&state, hook, NFPROTO_BRIDGE, indev, outdev,
                           sk, net, okfn);
 
        ret = nf_hook_slow(skb, &state, elem);
-       rcu_read_unlock();
        if (ret == 1)
                ret = okfn(net, sk, skb);
 
-- 
2.1.4

Reply via email to