From: jamal <[EMAIL PROTECTED]>
Date: Tue, 04 Jul 2006 13:11:56 -0400

> Clearly, this is a bad thing. Yes, the device in the first instance was
> at fault. But i have argued in the past that NAPI does just fine without
> flow control being turned on, so even chewing 5% of bandwidth on flow
> control is a bad thing..

I think it should be on by default.

If the machine is really busy, proper flow control keeps the
sender from overflowing the RX ring of the receiver.

Yes, with NAPI this happens less, but it does still happen.  And
I know that this is probably one of the least tested code paths
in every single driver, RX ring emptying out, and in fact the Tigon2
and the earliest Tigon3 chips would lock up on you if the RX ring
was emptied completely requiring a full chip reset when the watchdog
timer fired.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to