On Tue, 2006-07-04 at 11:51 +0200, Sam Ravnborg wrote: > On Tue, Jul 04, 2006 at 11:27:27AM +0200, Arjan van de Ven wrote: > > On Tue, 2006-07-04 at 02:25 -0700, Andrew Morton wrote: > > > On Tue, 04 Jul 2006 11:07:59 +0200 > > > Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > > > > patch below removes the use of UTS_RELEASE from the tiacx driver; there > > > > is absolutely no reason for a driver to print the kernel version or use > > > > the UTS_RELEASE field; in addition this field changes all the time so > > > > this causes spurious rebuilds.. > > > > > > http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-04-usb/usb-storage-uname-in-pr-sc-unneeded-message.patch > > > did it too. > > > > > > UTS_RELEASE doesn't change much. It's "2.6.17". > > > > no but the header that it's in changes all the time iirc, at least it > > used to (one of those kbuild regenerated files) > Yesterday I pushed a change that splitted include/linux/version.h in two > parts. > Now include/linux/version.h only contains: > #define LINUX_VERSION_CODE 132625 > #define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c)) > > And the file wil only be regenerated when the file-content actually > changes. > > And UTS_RELEASE has moved to include/linux/utsrelease.h which contains: > #define UTS_RELEASE "2.6.17-g05668381-dirty" > > This is the file that will change often - at least for git users. > But with the patch only users of UTS_RELEASE will be rebuild which is > far less than users of version.h.
which is a good thing, and we should keep users of utsrelease.h to a minimum... hence my patch to eliminate a user ;) (which used it to do a printk.. but if you use a kernel the version is already in dmesg, no need to printk it again :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
