Re: [PATCH] arp: Race condition in gratuitous ARP reception handling.

[David Miller]

From: <tomasz.dziec...@nokia.com>
Date: Thu, 2 Mar 2017 14:59:47 +0100

> @@ -836,19 +843,30 @@ static int arp_process(struct net *net, struct sock 
> *sk, struct sk_buff *skb)
>       n = __neigh_lookup(&arp_tbl, &sip, dev, 0);
>  
>       if (IN_DEV_ARP_ACCEPT(in_dev)) {
> -             unsigned int addr_type = inet_addr_type_dev_table(net, dev, 
> sip);
> +             unsigned int addr_type = inet_addr_type_dev_table(net,
> +                                                               dev, sip);

Please don't mix coding style changes with real modifications.

> +     } else if (n) {
> +             unsigned int addr_type = inet_addr_type_dev_table(net,
> +                                                               dev, sip);

Thanks.