From: "Randy.Dunlap" <[EMAIL PROTECTED]>
Date: Sun, 2 Jul 2006 14:36:11 -0700

> From: Randy Dunlap <[EMAIL PROTECTED]>
> 
> The first check for #ifdef XFRM6_TUNNEL_SPI_MAGIC needs to come after
> the optional #define of it, otherwise the variable won't be there
> for the rest of the code to use.
> 
> Shouldn't that CONFIG_IPV6_XFRM6_TUNNEL_DEBUG be part of Kconfig
> or have its name changed?
> 
> Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>

Yes, indeed.  Nothing named CONFIG_* should be defined explicitly
by the source files, only through Kconfig.

I would rather address that than apply this patch.

Thanks Randy.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to