On 21 February 2017 at 15:25, Jarno Rajahalme <ja...@ovn.org> wrote: > Commit 4dee62b1 ("netfilter: nf_ct_expect: nf_ct_expect_insert() > returns void") inadvertently changed the successful return value of > nf_ct_expect_related_report() from 0 to 1 due to > __nf_ct_expect_check() returning 1 on success. Prevent this > regression in the future by changing the return value of > __nf_ct_expect_check() to 0 on success. > > Signed-off-by: Jarno Rajahalme <ja...@ovn.org> > ---
It seems like other functions in this file return 0 as successful condition, so from that perspective this seems more in line with existing code. Acked-by: Joe Stringer <j...@ovn.org>