On Mon, Feb 13, 2017 at 12:55:03PM +0100, walter harms wrote:
>
>
> Am 13.02.2017 12:00, schrieb Dan Carpenter:
> > We had intended to say "sizeof(u32)" but the "u" is missing.
> > Fortunately, sizeof(32) is also 4, so the original code still works.
> >
> > Fixes: c4e7beea2192 ("net: qcom/emac: add ethtool support for reading
> > hardware registers")
> > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
> >
> > diff --git a/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> > b/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> > index 0d9945fb79be..bbe24639aa5a 100644
> > --- a/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> > +++ b/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> > @@ -227,7 +227,7 @@ static void emac_get_regs(struct net_device *netdev,
> >
> > static int emac_get_regs_len(struct net_device *netdev)
> > {
> > - return EMAC_MAX_REG_SIZE * sizeof(32);
> > + return EMAC_MAX_REG_SIZE * sizeof(u32);
> > }
> >
>
>
> We have a function where the argument is ignored and the rest is const ?
>
> emac_ethtool_get_regs_len seems the only user. So it would be fairly easy to
> move that into that function.
It's not the only user. We have to pass netdev because it's used as a
function pointer.
regards,
dan carpenter
