On Fri, 10 Feb 2017 09:38:20 -0800
Shannon Nelson <shannon.nel...@oracle.com> wrote:

> +static void vsw_get_ethtool_stats(struct net_device *dev,
> +                               struct ethtool_stats *estats, u64 *data)
> +{
> +     int i = 0;
> +
> +     data[i++] = dev->stats.rx_packets;
> +     data[i++] = dev->stats.tx_packets;
> +     data[i++] = dev->stats.rx_bytes;
> +     data[i++] = dev->stats.tx_bytes;
> +     data[i++] = dev->stats.rx_errors;
> +     data[i++] = dev->stats.tx_errors;
> +     data[i++] = dev->stats.rx_dropped;
> +     data[i++] = dev->stats.tx_dropped;
> +     data[i++] = dev->stats.multicast;

Please do not duplicate regular network statistics into ethtool.
This doesn't really add any value.

Reply via email to