> + phy_mode = device_get_phy_mode(dev); > + if (phy_mode < 0) { > + dev_err(dev, "Unable to get phy-connection-type\n"); > + return phy_mode; > + } > + pdata->resources.phy_mode = phy_mode; > + > + if (pdata->resources.phy_mode != PHY_INTERFACE_MODE_RGMII) { > + dev_err(dev, "Incorrect phy-connection-type specified\n"); > + return -ENODEV; > + }
This seems a bit limiting. What if you need to use: PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID, PHY_INTERFACE_MODE_RGMII_TXID, in order to set the RGMII delays. Andrew