On Fri, Jan 27, 2017 at 8:16 PM, Tom Herbert <t...@herbertland.com> wrote: > On Fri, Jan 27, 2017 at 10:05 AM, Saeed Mahameed > <sae...@dev.mellanox.co.il> wrote: >> On Fri, Jan 27, 2017 at 7:50 PM, Tom Herbert <t...@herbertland.com> wrote: >>> On Fri, Jan 27, 2017 at 9:38 AM, Saeed Mahameed >>> <sae...@dev.mellanox.co.il> wrote: >>>> On Fri, Jan 27, 2017 at 7:34 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: >>>>> On Fri, Jan 27, 2017 at 1:32 AM, Tom Herbert <t...@herbertland.com> wrote: >>>>>> Add a configuration option (CONFIG_MLX5_CORE_ESWITCH) for controlling >>>>>> whether the eswitch code is built. Change Kconfig and Makefile >>>>>> accordingly. >>>>> >>>>> Tom, FWIW, please note that the basic e-switch functionality is needed >>>>> also when SRIOV isn't of use, this is for a multi host configuration. >>>>> >>>> >>>> Right, set_l2_table_entry@eswitch.c need to be called by PF for any UC >>>> MAC address wanted by VF or PF. >>>> To keep one flow in the code, the implementation is done as part of >>>> eswitch. >>>> >>>> so in multi-host configuration (where there are 4 PFs) each PF should >>>> invoke set_l2_table_entry_cmd for each one of its own UC MACs. >>>> >>>> populating the l2 table is done using the whole eswitch event driven >>>> mechanisms, it is not easy and IMH not right to separate eswitch >>>> tables from l2 table (same management logic, different tables). >>>> >>>> Anyways as Or stated this is just an FYI, eswitch needs to be enabled >>>> on Multi-host configuration. >>>> >>> What indicate a multi-host configuration? >> >> nothing in the driver, it is transparent. >> > So then we always need the eswitch code to be built even if someone > never uses any of it? >
yes. but for your convenience all you need is to compile eswitch.c. esiwtch_offoalds.c and en_rep.c can be compiled out for basic ethernet. >>> >>>>> Or. >>>>> >>>>> My WW (and same for the rest of the IL team..) has ended so I will be >>>>> able to further look on this series and comment on Sunday.
