Adding Bob Bernstein Jon Pannell
-----Original Message----- From: Gregory CLEMENT [mailto:gregory.clem...@free-electrons.com] Sent: Tuesday, January 24, 2017 11:56 PM To: Andrew Lunn <and...@lunn.ch> Cc: Vivien Didelot <vivien.dide...@savoirfairelinux.com>; Florian Fainelli <f.faine...@gmail.com>; netdev@vger.kernel.org; linux-ker...@vger.kernel.org; David S. Miller <da...@davemloft.net>; Jason Cooper <ja...@lakedaemon.net>; Sebastian Hesselbarth <sebastian.hesselba...@gmail.com>; Thomas Petazzoni <thomas.petazz...@free-electrons.com>; linux-arm-ker...@lists.infradead.org; Nadav Haklai <nad...@marvell.com>; Wilson Ding <ding...@marvell.com>; Kostya Porotchkin <kos...@marvell.com>; Joe Zhou <shjz...@marvell.com>; Jon Pannell <jpann...@marvell.com> Subject: Re: [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 Hi Andrew, On mer., janv. 25 2017, Andrew Lunn <and...@lunn.ch> wrote: >> + [MV88E6341] = { >> + .prod_num = PORT_SWITCH_ID_PROD_NUM_6341, >> + .family = MV88E6XXX_FAMILY_6341, >> + .name = "Marvell 88E6341", >> + .num_databases = 4096, >> + .num_ports = 6, >> + .port_base_addr = 0x10, >> + .global1_addr = 0x1b, >> + .age_time_coeff = 15000, > > Hi Gregory > > Please could you check this timer in the datasheet. There is currently > a bug in the mv88e6390 support code. I also set it to 15s. But in fact > it is 3.75 seconds. The 6341 might also use 3.75 seconds. When I read your series I also thought about it and indeed it is 3.75 seconds. I will fix it. Thanks, Gregory > > Thanks > Andrew -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
