On Mon, 2006-06-26 at 12:29 -0400, Benjamin LaHaise wrote: > This part is good, although doing something for copper cards needs doing, > which probably means poking around to support the phy properly. I Agree. But i dont have a copper card, nor the knowledge to do this. I was actually hoping that someone could "fill in the blanks".
> > Also added a "disable_autoneg" module argument to completely disable > > autoneg on all cards using this driver. > > This is the part I disagree with. Are you sure it isn't a bug in the > link autonegotiation state machine for fibre cards? It should be defaulting > to 1Gbit/full duplex if no autonegotiation is happening, and if it isn't > then that should be fixed instead of papering over things with a config > option. In my setup, we use several fibercards on passive fiber-taps (tx only), thus there is no link partner. If i dont disable autoneg, i simply cant sniff traffic. Skipping the initial autoneg solved the problem. Adding ethtool support was just an extra courtesy upon request. After adding ethtool support, i kept the disable_autoneg option to allow one to operate with default autoneg disabled, and enabling autoneg through ethtool where needed. Sort of a "reverse operation" mode. If there IS a bug in the autoneg statemachine i would have no idea how to fix it. My knowledge of hardware & drivers is unfortunately extremely limited. - Dan - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
