From: "Randy.Dunlap" <[EMAIL PROTECTED]>
Date: Mon, 26 Jun 2006 15:29:39 -0700

> drivers/dma/ioatdma.c:830: warning: no return statement in function returning 
> non-void
> drivers/dma/ioatdma.c:830: warning: control reaches end of non-void function
> 
> Maybe insert "return" in front of:
> 
>       pci_module_init(&ioat_pci_drv);
> 
> or is there some reason not to do that?
> 
> BTW, pci_module_init() is obsolete.  Drivers should be using
> pci_register_driver() instead.
> 
> PS:  IOAT/DMA (whatever) needs a MAINTAINERS entry.

It also still has the cpu hotplug locking bug, which none of the
I/O AT developers have even mentioned that they'd try to fix.

To reiterate, it tries to lock hotplug while holding spinlocks
which is illegal because locking hotplug takes a semaphore which
can sleep.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to