From: Simon Horman <ho...@verge.net.au>
Date: Thu, 12 Jan 2017 16:46:47 +0100

> What I now see is that a few lines further up there is:
> 
>        if (skb_put_padto(skb, ETH_ZLEN))
>               goto drop;
> 
>       where ETH_ZLEN is 60.
> 
> So I don't think we need to worry about skb->len being less than 60 and
> this patch can be simplified to:
> 
>       if (len == 0)
>               len = 4;

I'd say this might deserve a comment...

Reply via email to