Às 3:26 PM de 1/12/2017, David Miller escreveu: > > I don't understand at all why it is so important to change the name of > these files nor the directory they live in.
GMAC4 is a nickname for the Designware Ethernet QoS, which began in version 4.x for historical reasons. Soon, we will have version eQOS 5.x version release and we will have some features in stmmac only available from version 5.x. If the dwmac4* files and functions were called eqos it would clearer and easier to include the 5.x stuff. > > What bonafide benefit will users receive if we do this? >From my point of view have a /net/ethernet/dwc/stmmac instead of a /net/ethernet/stmicro/stmmac will be clearer for users that it is the spot for Ethernet Designware IPs. This change will not cause any problems. We are going o have new Synopsys Ethernet IPs with new drivers that would be placed inside this /net/ethernet/dwc/. In my understanding the advantage is to prepare the future. Imagine that I am developing a new driver for a new Ethernet IP. So I work at Synopsys, I am developing a driver for Ethernet EXAMPLE IP. Where would put it? This is my concern to the future. > > The only clear part is the downside, which is that it is going to make > it painful to browse source history and backport bug fixes. > > Please, let's not do this. > > Thanks. > Thanks, Joao
