On Wed, Jan 11, 2017 at 7:46 AM, David Miller <da...@davemloft.net> wrote: > From: Michael Chan <michael.c...@broadcom.com> > Date: Tue, 10 Jan 2017 20:12:38 -0500 > >> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.h >> b/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.h >> index 35a0d28..f2630cc 100644 >> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.h >> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.h >> @@ -36,6 +36,9 @@ struct bnxt_cos2bw_cfg { >> >> #define HWRM_STRUCT_DATA_SUBTYPE_HOST_OPERATIONAL 0x0300 >> >> +#define ETH_P_ROCE 0x8915 > > There's also a similar define in the qedr infiniband driver, this doesn't > make much sense. > > Please add this to if_ether.h, and reference it from there in the drivers. > My colleague informed me that he has submitted a patch to do that through the rdma tree:
http://marc.info/?l=linux-rdma&m=148217575500983&w=2 But it hasn't been merged yet. I can drop this patch now and wait for the RDMA patch to show up on net-next. Or I make the change later to use the common define when the RDMA patch is merged. Thanks.