On Fri, 2016-12-09 at 19:31 -0600, Thomas Falcon wrote: > This patch is based on an earlier one submitted > by Jon Maxwell with the following commit message: >
> + DIV_ROUND_UP(skb->len - hdr_len, mss); > + } else if (offset) { > + skb_shinfo(skb)->gso_size = ntohs(tcph->check); > + skb_shinfo(skb)->gso_segs = > + DIV_ROUND_UP(skb->len - hdr_len, > + skb_shinfo(skb)->gso_size); > + tcph->check = 0; > + } Are you sure that tcph->check could never be 0 on some cases ? That would crash on a divide by 0