On 12/05/2016 12:36 PM, David Miller wrote:
> From: Florian Fainelli <f.faine...@gmail.com>
> Date: Sun, 4 Dec 2016 19:22:05 -0800
>
>> When we unload the ep93xx_eth, whether we have opened the network
>> interface or not, we will either hit a kernel paging request error, or a
>> simple NULL pointer de-reference because:
>>
>> - if ep93xx_open has been called, we have created a valid DMA mapping
>> for ep->descs, when we call ep93xx_stop, we also call
>> ep93xx_free_buffers, ep->descs now has a stale value
>>
>> - if ep93xx_open has not been called, we have a NULL pointer for
>> ep->descs, so performing any operation against that address just won't
>> work
>>
>> Fix this by adding a NULL pointer check for ep->descs which means that
>> ep93xx_free_buffers() was able to successfully tear down the descriptors
>> and free the DMA cookie as well.
>>
>> Fixes: 1d22e05df818 ("[PATCH] Cirrus Logic ep93xx ethernet driver")
>> Signed-off-by: Florian Fainelli <f.faine...@gmail.com>
>
> Applied, thanks Florian.
Thanks! Can you also queue this one for -stable? The original commit
dates back from 2006, but it should apply with minor hunks to all
-stable kernels.
Cheers
--
Florian
