On 12/05/2016 08:49 AM, Rob Herring wrote: > On Mon, Nov 28, 2016 at 05:04:23PM -0600, Grygorii Strashko wrote: >> From: WingMan Kwok <w-kw...@ti.com> >> >> This patch adds support of the cpts device found in the >> gbe and 10gbe ethernet switches on the keystone 2 SoCs >> (66AK2E/L/Hx, 66AK2Gx). >> >> Signed-off-by: WingMan Kwok <w-kw...@ti.com> >> Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> >> --- >> .../devicetree/bindings/net/keystone-netcp.txt | 9 + >> drivers/net/ethernet/ti/Kconfig | 7 +- >> drivers/net/ethernet/ti/netcp.h | 2 +- >> drivers/net/ethernet/ti/netcp_core.c | 18 +- >> drivers/net/ethernet/ti/netcp_ethss.c | 437 >> ++++++++++++++++++++- >> 5 files changed, 459 insertions(+), 14 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/keystone-netcp.txt >> b/Documentation/devicetree/bindings/net/keystone-netcp.txt >> index 04ba1dc..c37b54e 100644 >> --- a/Documentation/devicetree/bindings/net/keystone-netcp.txt >> +++ b/Documentation/devicetree/bindings/net/keystone-netcp.txt >> @@ -113,6 +113,15 @@ Optional properties: >> will only initialize these ports and attach PHY >> driver to them if needed. >> >> + Properties related to cpts configurations. >> + - cpts_clock_mult/cpts_clock_shift: > > Needs vendor prefix. Don't use '_'.
This module is used as part of OMAP and Keystone SoCs, so names for this props is ABI already :( > >> + used for converting time counter cycles to ns as in >> + >> + ns = (cycles * clock_mult) >> _shift >> + >> + Defaults: clock_mult, clock_shift = calculated from >> + CPTS refclk > > What does this mean? > I'll add more description here. >> + >> NetCP interface properties: Interface specification for NetCP sub-modules. >> Required properties: >> - rx-channel: the navigator packet dma channel name for rx. -- regards, -grygorii
