From: Eric Dumazet <eric.duma...@gmail.com> Date: Sat, 03 Dec 2016 17:13:51 -0800
> On Sat, 2016-12-03 at 19:16 -0500, David Miller wrote: >> From: Eric Dumazet <eduma...@google.com> >> Date: Sat, 3 Dec 2016 11:14:57 -0800 >> >> > diff --git a/include/linux/tcp.h b/include/linux/tcp.h >> > index d8be083ab0b0..fc5848dad7a4 100644 >> > --- a/include/linux/tcp.h >> > +++ b/include/linux/tcp.h >> > @@ -186,7 +186,6 @@ struct tcp_sock { >> > u32 tsoffset; /* timestamp offset */ >> > >> > struct list_head tsq_node; /* anchor in tsq_tasklet.head list */ >> > - unsigned long tsq_flags; >> > >> > /* Data for direct copy to user */ >> > struct { >> >> Hmmm, did you forget to "git add include/net/sock.h" before making >> this commit? > > sk_tsq_flags was added in prior patch in the series ( 7/8 net: > reorganize struct sock for better data locality) > > What is the problem with this part ? Sorry, just noticed by visual inspection. I expected the struct sock part to show up in the same patch as the one that removed it from tcp_sock and adjusted the users. I'll re-review this series, thanks.