Hi Andrew,
Andrew Lunn <and...@lunn.ch> writes:
>> You can have several implementations in the same file (e.g. global1.c),
>> so again the only value is the function name, not the struct member.
>
> The structure member have g1_ has a lot of value.
>
> if (chip->info->ops->set_cpu_port) {
> err = chip->info->ops->set_cpu_port(chip, upstream_port);
> if (err)
> return err;
> }
>
> Where to i need to go look for set_cpu_port? I have no idea.
In your chip's ops definition, as for any ops structure. Same as for
your example right below which is unfortunately not a solution per-se.
>
> if (chip->info->ops->g1_set_cpu_port) {
> err = chip->info->ops->g1_set_cpu_port(chip, upstream_port);
> if (err)
> return err;
> }
>
> Humm, the hint tells me it is in global1.c. And i also know that all
> of them are in global1.c.
Until a new chip relocates a feature somewhere else.
Then you'll have to rename the structure member(s) because you have a
policy saying "no prefix means different set of registers".
Vivien
