Fri, Dec 02, 2016 at 10:59:42AM CET, simon.hor...@netronome.com wrote: >Add support for matching on ICMP type and code to flower. This is modeled >on existing support for matching on L4 ports. > >The second patch provided a minor cleanup which is in keeping with >they style used in the last patch. > >This is marked as an RFC to match the same designation given to the >corresponding kernel patches.
Looks nice, I only have those 2 enum nitpicks. Thanks. > >Based on iproute2/net-next with the following applied: >* [[PATCH iproute2/net-next v2] 0/4] tc: flower: SCTP and other port fixes > >Simon Horman (3): > tc: flower: update headers for TCA_FLOWER_KEY_ICMP* > tc: flower: introduce enum flower_endpoint > tc: flower: support matching on ICMP type and code > > include/linux/pkt_cls.h | 10 ++++ > man/man8/tc-flower.8 | 20 ++++++-- > tc/f_flower.c | 118 ++++++++++++++++++++++++++++++++++++++++++------ > 3 files changed, 129 insertions(+), 19 deletions(-) > >-- >2.7.0.rc3.207.g0ac5344 >
